Skip to content

Use proper sync resolution in CI #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use proper sync resolution in CI #1325

wants to merge 2 commits into from
+7 −2

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Aug 30, 2025

No description provided.

@Kludex Kludex requested a review from a team as a code owner August 30, 2025 21:01
@Kludex Kludex requested a review from dsp-ant August 30, 2025 21:01
@Kludex Kludex mentioned this pull request Aug 30, 2025
Merged
4 tasks
@Kludex
Copy link
Member Author

Kludex commented Aug 30, 2025

@maxisbey Do you have time to debug this?

@maxisbey
Copy link
Contributor

maxisbey commented Sep 1, 2025

@maxisbey Do you have time to debug this?

Pretty sure it's because of this function here:

python-sdk/tests/client/test_config.py

Line 26 in 5439619

def test_command_execution(mock_config_path: Path):

It runs a uv command built here:

python-sdk/src/mcp/cli/claude.py

Line 67 in 4fee123

uv_path = get_uv_path()

This is then run without uv --frozen and without whatever dependency resolution is being set by the changes you made in this PR. So the unit test times out since it's re-installing a bunch of dependencies due to the different dependency version resolution uv is using when launched inside the unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsp-ant dsp-ant Awaiting requested review from dsp-ant dsp-ant is a code owner automatically assigned from modelcontextprotocol/python-sdk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kludex @maxisbey @dsp-ant